Test: add URL to re2 rubygems.org page to assert#58
Merged
mattyoho merged 1 commit intogithub:masterfrom Jan 25, 2019
Merged
Conversation
- adds armchair "developer experience"
mattyoho
approved these changes
Jan 25, 2019
Contributor
mattyoho
left a comment
mattyoho
left a comment
There was a problem hiding this comment.
Thanks for the ergonomics patch!
| t0 = Time.now | ||
| email("pathological") | ||
| assert (Time.now - t0) < 1, "Took too long, upgrade to re2 gem." | ||
| assert (Time.now - t0) < 1, "Took too long, upgrade to re2 gem. See https://rubygems.org/gems/re2" |
Contributor
There was a problem hiding this comment.
Slightly tweaking the error message language:
Suggested change
| assert (Time.now - t0) < 1, "Took too long, upgrade to re2 gem. See https://rubygems.org/gems/re2" | |
| assert (Time.now - t0) < 1, "Parsing took too long, please install the re2 gem locally. See https://rubygems.org/gems/re2" |
Contributor
There was a problem hiding this comment.
Ah, maintainers aren't able to edit the upstream. 🙂Accepting as-is. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the rubygems.org URL to the re2 gem to the assert failure message that tells you to install it.